[FIX] middleware/testRunner: Update resources from OpenUI5#349
Merged
Conversation
Member
Author
|
Not yet tested |
matz3
force-pushed
the
update-testrunner-resources
branch
from
0d4cc38 to
f560c33
Compare
matz3
force-pushed
the
update-testrunner-resources
branch
from
f560c33 to
e3da348
Compare
Member
|
Added a script to do the update. But I also didn't verify the changes at runtime, yet. |
RandomByte
commented
Sep 1, 2020
|
|
||
| # Get latest commit url for src/sap.ui.core/test/sap/ui/qunit path | ||
| COMMIT_URL=$(curl "https://api.github.com/repos/SAP/openui5/commits?sha=master&path=src/sap.ui.core/test/sap/ui/qunit" | \ | ||
| node -r fs -e "process.stdout.write(JSON.parse(fs.readFileSync(\"/dev/stdin\", \"utf8\"))[0].html_url)") |
Member
Author
There was a problem hiding this comment.
An alternative would be jq. Needs to be installed however
Member
|
Works fine with the openui5-sample-app 👍🏻 Why not also using ETag caching here? |
Member
|
Just pushed my change for ETag caching. We can still decide if we want to enable it or stick with the 180s caching. |
matz3
force-pushed
the
update-testrunner-resources
branch
from
779f6e1 to
e3da348
Compare
Member
|
Extracted etag caching to #354 so that we can just merge the update. |
matz3
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.